NBitcoin > 7.0.24 - BitcoinStream.ReadWrite(ref byte[]) does not work anymore

MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.

MIT License

1.87k stars 846 forks source link

NBitcoin > 7.0.24 - BitcoinStream.ReadWrite(ref byte[]) does not work anymore #1200

Open blackmennewstyle opened 8 months ago

blackmennewstyle commented 8 months ago

Hello beautiful devs,

Since NBitcoin > 7.0.24, it's not possible anymore to perform BitcoinStream.ReadWrite(ref byte[])

error CS0311: The type 'byte[]' cannot be used as type parameter 'T' in the generic type or method 'BitcoinStream.ReadWrite<T>(ref T)'. There is no implicit reference conversion from 'byte[]' to 'NBitcoin.IBitcoinSerializable'

Is it normal?

blackmennewstyle commented 8 months ago

Nevermind, i found that PR pretty explicit about the reason: https://github.com/MetacoSA/NBitcoin/pull/1173