search

MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.
MIT License
1.87k stars 846 forks source link

Feature request: UAHF support #264

Closed ab-4797DD45889F closed 7 years ago

ab-4797DD45889F commented 7 years ago

Hello,

Your project is really awesome ! It makes bitcoin and litecoin related projects much simpler.

Due to forthcoming uahf it would be great to add some changes to prevent double spending and add replay protection.

Please have a look at https://github.com/Bitcoin-UAHF/spec/blob/master/uahf-technical-spec.md Especially REQ-6-2

Thanks in advance

knocte commented 7 years ago

Typo: I think you meant MAHF, not UAHF.

NicolasDorier commented 7 years ago

Double spending has to be prevented by the forking chain, this is not a concern for NBitcoin.

If you are talking about using the new SIGHASH of Bitcoin Cash, I will make an alternate branch with only a change to sign with this SIGHASH. It will not be merged to main branch though.

NicolasDorier commented 7 years ago

Created a branch for signing with Bitcoin Cash on https://github.com/MetacoSA/NBitcoin/tree/BCCtemp I will not integrate on main branch though as Bitcoin Cash change might conflict later with Bitcoin.

ab-4797DD45889F commented 7 years ago

Thank you