search

MetacoSA / NBitpayClient

A non official library for using bitpay's API
MIT License
19 stars 18 forks source link

send rates signed to support btcpayserver's slightly different rates api requirement #15

Closed Kukks closed 6 years ago

NicolasDorier commented 6 years ago

Actually the rate should not need to be signed.

Kukks commented 6 years ago

No they don't but to connect to the new btcpayserver ones we need a way to get the store id and I think if you sign it, we can resolve it from that.

I don't think think there is any harm of signing it anyway right?

On Jul 28, 2018 13:55, "Nicolas Dorier" notifications@github.com wrote:

Actually the rate should not need to be signed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MetacoSA/NBitpayClient/pull/15#issuecomment-408602179, or mute the thread https://github.com/notifications/unsubscribe-auth/ABu-_nXt7iG8-av3zQztFsKerGUxy8PPks5uLFEsgaJpZM4Vk_Gh .

NicolasDorier commented 6 years ago

Oh I see that's indeed cool.

NicolasDorier commented 6 years ago

It still works fine on bitpay?