Metacor / nyaa-linker

Adds a button to Anime and Manga database websites that opens a relevant Nyaa search
GNU General Public License v3.0
6 stars 1 forks source link

Searching sort options does not work other except Fuzzy #6

Closed ghost closed 9 months ago

ghost commented 9 months ago

Issue

https://anilist.co/anime/137877/Ganbare-Doukichan/ and try other all sort settings.

Expected Behavior

Give results

Which Browser, and Browser Version are you using?

Edge Version 120.0.2210.91

Which Extension Version are you using?

v1.2.0

Metacor commented 9 months ago

This seems to be a case of an odd naming choice by anilist. I don't see how this could be fixed, because as I will detail below, this is the intended result given the title information. The only way to avoid this is to either use Fuzzy matching, or to use MyAnimeList. (Although to be clear, using anilist shouldn't be an issue for the vast majority of anime, it typically only happens for anime that have weird punctuation, and even then it's still pretty rare.)

The show is called "がんばれ同期ちゃん", which should be: Romaji: Ganbare Douki-chan English: Do Your Best, Douki-chan

For some reason, on anilist it is: Romaji: Ganbare, Douki-chan (with a comma, which isn't typically used in romaji conversions) English: GANBARE DOUKICHAN (which isn't english at all, and also doesn't include a hyphen for the honorific)

From what I can tell, most nyaa uploaders tend to use the MyAnimeList naming schemes, so if you're not using MAL when searching, sometimes the names might not match.

"Exact" is searching for "Ganbare, Douki-chan"|"GANBARE DOUKICHAN", which is searching for something that matches EXACTLY one of those two terms, and since the listings on nyaa are for "Ganbare Douki-chan", neither search term will match it exactly, and thus will return no results.

"Base" only comes into play when there is stuff like parts/seasons in the title, where it will attempt to remove those and leave you with just the "base" series title ["Series Season 2" → "Series"], if there is no match for this, it just uses "Exact".

"Default" is just a combination of Base and Exact, so in this case, all 3 options are functionally identical. Additionally all options default to "Fuzzy" if there is only a single title or if the Japanese and English titles are the same; such as Jujutsu Kaisen, or funnily enough, the Ganbare Douki-chan listing on MyAnimeList.

"Fuzzy" was made so you're able to search for non-exact titles, for cases specifically like this, where there is a weird naming decision (either by the database website, or by the nyaa uploaders).