Resolution diamond corresponds to the wrong date

[hickman-santini]

Current behavior

I resolved this just now with resolution date/time of Sep 4 10:22 AM, but the diamond shows up on August 28.

Expected/desired behavior

The diamond should show on the day the resolution was known, and potentially the community prediction should be cut off at that time? @SylvainChevalier can you confirm desired behavior here.

[SylvainChevalier]

I see two issues:

1. The "actual close time" failed to be set to the resolution time.
2. The diamond doesn't match any of the question's dates.

See Django admin:

[hlibowski]

@hickman-santini Hm, can't replicate wrong diamond behaviour, but found another issue -- "resolved" lable always shows scheduled and not actual resolved time

@George3d6 @lsabor Do we need to add actual_resolve_time for the post model like we do for Post.actual_close_time? Currently, we don’t show correct “Resolved” datetime after question closure since it takes values from Post.scheduled_resolve_time regardless of actual dt provided in resolution modal.

[hickman-santini]

Something is still weird @hlibowski like this one I just resolved with resolution time today (Sep 13) 4PM but it appears as though the diamond is on Aug 12. This is on dev:

Also there it says resolved Nov 25, 2025? That's extra weird.

Wait a minute.... when I went back to dev.metaculus.com/questions/7596 just now the resolution diamond had moved! Now it looks right. :fearful:

[George3d6]

@lsabor can you look at this, it looks like the resolution to datetime conversion is probably wrong (?)

[hlibowski]

@hickman-santini

Also there it says resolved Nov 25, 2025? That's extra weird. It's Scheduled Resolve Time which is just an assumption. The Actual Resolve Time is correct -- this is what I see.

Yeah, something wrong with appearance indeed. I'm not familiar with that part, so reassigning to @lsabor

[hickman-santini]

Thanks @hlibowski

@lsabor one issue seems easy to resolve - when a question is resolved, above the graph it should say "Resolved [actual resolve time]" not scheduled resolve time.

The other issue I'm not sure how to diagnose since it resolved itself almost immediately (when I navigated away from and then back to the page), but at first it looked like that screenshot above with the diamond on Sep 9 or so when it should have been Sep 13.

[lsabor]

It seems like the resolution diamond has appeared on top of the most recent CP. Simple fix - on it

[lsabor]

I've fixed this issue, so closing. There is another issue, probably not blocking, where the "resolved at" time for group questions is messy. It might require (at least for now) adding actual_resolve_time to the Post object.