search

Metadrop / drupal-boilerplate

Drupal projects up and running with Docker and many other tools in minutes
28 stars 23 forks source link

Remove version from docker as it is deprecated #136

Closed Eduardo-Morales-Alberti closed 3 months ago

Eduardo-Morales-Alberti commented 3 months ago

Warning:

time="2024-03-22T08:03:03+01:00" level=warning msg="/var/lib/jenkins/workspace/schaer-schaer_tests_PR-462/docker-compose.yml: version is obsolete" time="2024-03-22T08:03:03+01:00" level=warning msg="/var/lib/jenkins/workspace/schaer-schaer_tests_PR-462/jenkins/docker-compose.override.yml: version is obsolete"

Solution: https://github.com/mailcow/mailcow-dockerized/issues/5797#issuecomment-2010649543

Please remove the version line from the docker-compose.yml file and verify that everything still works correctly on your end. Docker has made this line obsolete, which is likely the reason you're facing this issue

omarlopesino commented 3 months ago

Adding the official information to the pull request to the information https://docs.docker.com/compose/compose-file/04-version-and-name/ . As edu and the issue referenced mentions the version attribute is not neccesary anymore and only used for backwards compatibility. We can remove it, and if any project needs it, it can be manually added to support older versions.

Merging, thanks!