Metadrop / drupal-boilerplate

Drupal projects up and running with Docker and many other tools in minutes
28 stars 23 forks source link

Review drupal-project drupal-scaffold composer configuration #34

Closed omarlopesino closed 3 years ago

omarlopesino commented 3 years ago

Currently, there are some lines added in te composer.json's script section that belongs to the Drupal project.

The first line belongs to the Plugin class of drupal-scaffold, a package that we currently do not require:

 "drupal-scaffold": "DrupalComposer\\DrupalScaffold\\Plugin::scaffold",

This line can be removed directly.

The other lines belong to the drupal-project template, and they are currently functional in this boilerplate:

        "pre-install-cmd": [
            "DrupalProject\\composer\\ScriptHandler::checkComposerVersion"
        ],
        "pre-update-cmd": [
            "DrupalProject\\composer\\ScriptHandler::checkComposerVersion"
        ],
        "post-install-cmd": [
            "DrupalProject\\composer\\ScriptHandler::createRequiredFiles"
        ],
        "post-update-cmd": [
            "DrupalProject\\composer\\ScriptHandler::createRequiredFiles"
        ]

As now the drupal recommended project exists, I am not sure if the functionality provided by the drupal-project is already provided by the recommended project. That's why I open this issue, to ensure the drupal-project lines are still necessary or there is a more recent and stable alternative.

omarlopesino commented 3 years ago

Fixed in