Metadrop / drupal-boilerplate

Drupal projects up and running with Docker and many other tools in minutes
28 stars 23 forks source link

Fix errors in the base tooling #51

Closed albeorte96 closed 3 years ago

albeorte96 commented 3 years ago

Some of the tools installed with boilerplate were causing errors that have been corrected in this pull request (behat test and coding standards analysis with phpqa).

omarlopesino commented 3 years ago

Behat fixes looks good to me. For phpcs too, as in 1.25 version they removed that Phpcs3 class: https://github.com/EdgedesignCZ/phpqa/pull/232

One thing @albeorte96: both commits solve problems that don't have any relationship between them, for that reason should be treated in different pull requests. However, as those are minor fixes I think it is easier to merge them now as they are ok. Please, next time try to make separate pull requests so that help to review better the changes.

Thanks!