Metadrop / drupal-boilerplate

Drupal projects up and running with Docker and many other tools in minutes
28 stars 23 forks source link

Version 1.2.2 requires a file from 2.x #67

Closed idiazroncero closed 2 years ago

idiazroncero commented 2 years ago

Steps to reproduce

Setting up .env file
Setting up Drush aliases file

  [ErrorException]                                                                                              
  file_get_contents(./drush/sites/sitename.site.yml.example): Failed to open stream: No such file or directory  

And yes, the sitename.site.yml.example is a file that seems to be present on the 2.x branch but not on the 1.x. It seems to be a leak from 2.x development back into the 1.x branch.

rsanzante commented 2 years ago

Confirmed!

The problem is related to metadrop/drupal-dev and Scripthor. Scripthor, since this commit,, expects a sitename.site.yml file that is only in the 2.x boilerplate.

The solution is to restrict the Scripthor version in the boielrplate 1.x. To do this, we need to restrict metadrop/drupal-dev because is the package that requires Scripthor (the boilerplate includes Scripthor through metadrop/drupal-dev).

rsanzante commented 2 years ago

Fixed! New release 1.2.3 created.

Thanks!

rsanzante commented 2 years ago

However, it is better to use the 2.x branch. I'm creating a stable release for the 2.x.

idiazroncero commented 2 years ago

Glad to see 2.x becoming stable!