search

Metadrop / drupal-boilerplate

Drupal projects up and running with Docker and many other tools in minutes
28 stars 23 forks source link

Updated Grumphp with more checks #96

Closed juanjol closed 1 year ago

juanjol commented 1 year ago

I have added several rules that I consider necessary in our daily workflow, please check if they fit.

omarlopesino commented 1 year ago

Merging. About the topic raised here: https://github.com/Metadrop/drupal-boilerplate/pull/96/files#discussion_r1088967027 , solutions should be offered to solve the problems that imply blocking commits into develop: https://github.com/Metadrop/drupal-boilerplate/pull/96#discussion_r1088967027 , otherwise I completely disagree.

omarlopesino commented 1 year ago

I've had to fix a typo in the composer.json https://github.com/Metadrop/drupal-boilerplate/commit/96f809cc92c76b1fb0172034b82859d5f9441395 that made it malformed. The composer.json hasn't been tested before doing the PR. Plus, I think that maybe we could incorporate automated tests to the github repository to prevent this issues to happen. This is a good example for this.

Besides that, I've realized that the PHP compatibility package is a package that should belong to metadrop/drupal-dev. I will work on it as soon as I can, however, PRs are welcome.

juanjol commented 1 year ago

Thank you for the merge! I have to make some clarifications about the last messages to be in sync. Thank you for fixing the typo, I've tested grumphp in another project, maybe there was an error when passing the code to the boilerplate, my bad.

And about the develop branch problem, I think there is no problem now that I whitelisted develop. We don't need to provide any solution if we don`t want to block the branch. The only thing I can think of is that when the projects are already in an advanced state of maturity, the grumphp.yml of the project should be modified with the consent of the team to lock the branch since in those states those commits are not needed as much. But I understand that this should be a discussion to be considered at project development time, not here.