Open mihaisebea opened 4 years ago
Hi Mihai, thank you for another fix!
I guess the PR can be approved, but I'd like to have some more info on the issue before merging it. Can you please answer these questions?
Unknown
templates timeElapsed
under the default time to be ignored in the BuildTimeline.json
report? I think it's 10ms
right now. If it is, it means we'd have this same issue in the timeline report if we passed the timeline_ignore_templates_under
argument and it might mean it's a bug in the compiler. Otherwise that'd be an issue in this report.Thanks 👍
Hi @MetanoKid I used Visual Studio 2019 16.7.2 Seems the default is indeed 10ms but I have templates that take well over 500ms.
As far as i'm debugging this, in this function:
void TemplateInstantiationsAnalyzer::OnTemplateInstantiation(const CppBI::Activities::TemplateInstantiation& templateInstantiation)
{
there are plenty instantiations that have PrimaryTemplateSymbolKey and SpecializationSymbolKey 0 (zero)
And this is what the event looks like.
Unfortunately is not easy to create a simple reproducible case. It seems that SpecializationID is 0. I will try to look more into this.