Metastruct / simplethirdperson

A Garry's mod addon ~ Simple third person
Apache License 2.0
5 stars 3 forks source link

Simple Third Person integration/compatibility into TFA Base #1

Open Servius opened 7 years ago

Servius commented 7 years ago

Heyo. Solid addon. Functionality wise everything is working however it seems the universal use of the context menu has created some unintended conflicts. The TFA weapons Base uses the context menu to bring up the inspection system which allows players to look at the stats for their weapon and add/remove attachments. When the inspection menu opens it hides the third person menu making it unable to be used. If possible please make it so the third person menu can be integrated into the inspection menu. I was thinking an easy way of doing this would be to have the "Third Person Icon" be displayed in the TFA Base Inspection Menu if present.

Servius commented 7 years ago

Okay nevermind. I was able to override the tfa base override of the concept menu. I guess my next question is, can you pretty please make it so the simple thirdperson menu will stay open until the c button is tapped again?

Servius commented 7 years ago

Currently looks like this but only when I hold down the button "c" http://prntscr.com/f2d95c

Servius commented 7 years ago

https://hastebin.com/rupesacuku.lua This is the block of code I modified. I just commented out the override on the tfa side.

Servius commented 7 years ago

simple_thirdperson_menu (Opens simple_thirdperson menu) Doesnt seem to work. I was hoping to work around the override by making it so when a player taps c itll open the menu and do the con command.

edunad commented 7 years ago

Sorry for the late response, for some reason GitHub din't notify me. simple_thirdperson_menu should be working, strange. I'll look into that, might be broken

Servius commented 7 years ago

@edunad thank you.