search

Metaswitch / clearwater-docker

Docker integration for Project Clearwater
Other
41 stars 64 forks source link

Kubernetes #57

Closed parwinderet closed 7 years ago

mirw commented 7 years ago

@parwinderet, I suspect you're not actually looking to get this merged for now? Assuming not, I'm assigning this pull request to you so that it doesn't accidentally get picked up and someone review it - please assign it to someone when you want it to be reviewed. Thanks!

resouer commented 7 years ago

This is a very nice PR, why it is not get merged?

The code/scripts of clearwater is buggy (full of hard coded DNS name). It should be fixed.

mirw commented 7 years ago

@parwinderet, are you looking to get this merged? Please let us know.

@resouer, I think the current master branch works for stand-alone Docker (i.e. without Kubernetes) - I'm not sure whether the kubernetes branch works with stand-alone Docker - do you know?

Regarding "code/scripts of Clearwater is buggy (full of hard coded DNS name)", can you be more specific - are you referring to https://github.com/Metaswitch/clearwater-docker/blob/fab6292280fa9e324058e0bb818b50039038a013/base/Dockerfile#L47 or something else?

Thanks!

resouer commented 7 years ago

Yes, I am referring the DNS names in Dockerfiles. It concerns me a lot since Kubernetes DNS follows RFC while docker doesn't.

Btw, it seems mgm_kubernetes is a promising branch?

parwinderet commented 7 years ago

Hi,

Yes I am able to launch Clearwater and end to end call with kubernetes. So want to merge my changes but not sure how to do that.

On Apr 18, 2017 4:43 PM, "mirw" notifications@github.com wrote:

@parwinderet https://github.com/parwinderet, are you looking to get this merged? Please let us know.

@resouer https://github.com/resouer, I think the current master branch works for stand-alone Docker (i.e. without Kubernetes) - I'm not sure whether the kubernetes branch works with stand-alone Docker - do you know?

Regarding "code/scripts of Clearwater is buggy (full of hard coded DNS name)", can you be more specific - are you referring to https://github.com/Metaswitch/clearwater-docker/blob/ fab6292280fa9e324058e0bb818b50039038a013/base/Dockerfile#L47 or something else?

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Metaswitch/clearwater-docker/pull/57#issuecomment-294788587, or mute the thread https://github.com/notifications/unsubscribe-auth/AOj7LG4KTMNdkWapINK4kcPB9sp_E1BGks5rxJrkgaJpZM4LFWxS .

resouer commented 7 years ago

@parwinderet @mirw Great to hear about it! Do you know anyone who has write access to this repo?

btw, I think you need to squash your commits before that.

resouer commented 7 years ago

@parwinderet I also noticed in your base's Dockefile, there is a COPY repo_certs.zip /tmp/ which is outdated since no repo_certs.zip in this repo anymore.

Maybe rebase && squash && re-test is needed.

resouer commented 7 years ago

Also cc @MatMeredith since you are working on mgm_kubernetes branch