search

Metaswitch / clearwater-docker

Docker integration for Project Clearwater
Other
41 stars 64 forks source link

Add support for deployment with helm #85

Closed yujunz closed 6 years ago

yujunz commented 6 years ago

+1 for a single command and one source of truth. I will update the patch according to your comments :-)

yujunz commented 6 years ago

Ready for review @johadalin

Tested in GKE.

johadalin commented 6 years ago

@yujunz this looks great. All fits nicely into the gencfg script now. Tested it out on our kubernetes rig as well, and it all seems to work as expected, at least for basic function. Hope to have some time soon to play around with the wider function that Helm might give us, for upgrading deployments etc. so thanks again for sending this change over :)

Given it all works, I'm going to merge this down. Do feel free to send over any more enhancements if you make them in future; if one of us doesn't pick it up that quickly, tag me/someone else on the project, or assign it to one of us if you can (not sure on the repo permissions here. I'll check into it)

yujunz commented 6 years ago

assign it to one of us if you can (not sure on the repo permissions here. I'll check into it)

Thanks for the hint, @johadalin. It seems I don't have permission to make assignments.

johadalin commented 6 years ago

Cool. I'll see if it's possible to change that, and if not, just @ tag us :)