search

Metaswitch / clearwater-docker

Docker integration for Project Clearwater
Other
41 stars 64 forks source link

Compose: Specify image names #95

Closed iwaseyusuke closed 5 years ago

iwaseyusuke commented 5 years ago

For the convenience, this patch fixes to specify the image names in the compose file. Otherwise, Compose will name each image like clearwater-docker_<node_name>, and it is not convenient to manage the images on Docker registry.

Also removes some trailing whitespaces.

iwaseyusuke commented 5 years ago

Excuse me for jumping in. Could you review my PR when you have time? Thanks.

JamesGiblin commented 5 years ago

Apologies for the delay here. If you'd like to contribute to Project Clearwater, then we need you to first sign a contributors agreement - This covers the legalities, confirming that you retain ownership of your contributions and that you are licensing them to us.

Could you please let me know at contributor-agreement@metaswitch.com if you’d like to do this.

iwaseyusuke commented 5 years ago

@JamesGiblin Thank you for your reply. Sure, I will send an e-mail to that address later. If there some guidelines I have to read, please let me know. Thanks.

JamesGiblin commented 5 years ago

Thanks @iwaseyusuke. I look forward to your mail.

anneboffey commented 5 years ago

I have completed the review. I have one comment. Other than that it looks good.

iwaseyusuke commented 5 years ago

@anneboffey Thank you for reviewing my PR. I have just updated my PR for your comment.

iwaseyusuke commented 5 years ago

Thank you!