search

Metaswitch / floki

Launch containers to help build your software
MIT License
66 stars 21 forks source link

Bug in docker-in-docker in floki 0.6.0 #108

Closed maxdymond closed 4 years ago

maxdymond commented 4 years ago

unknown flag: --link alongguid:floki-docker See 'docker run --help'. 07:04:50 [ERROR] A problem occured: Running container failed: docker run exited with return code 125

maxdymond commented 4 years ago

Fix suggested by @matt-williams is https://github.com/Metaswitch/floki/blob/master/src/command.rs#L195:

        .add_docker_switch("--link")
        .add_docker_switch(&format!("{}:floki-docker", dind.name()))
rlupton20 commented 4 years ago

Makes sense. I'm sure I grepped for these when I changed the add_docker_switch, but must have missed this.

We ought to think about some basic regression testing of this kind of stuff too. It's a little light at present.

rlupton20 commented 4 years ago

I labelled 0.6.0 as a bad release - I'm not sure if we can/should retract it.