Open spdegabrielle opened 3 years ago
Related to #24
closed #24 - as my thinking has moved on.
Do any of these scripts introduce new pkg-level dependencies?
If not, may I see their code to look into the module-level dependencies?
Yes, command palette
, depends on search-list-box
https://pkgs.racket-lang.org/package/search-list-box
source: https://github.com/Metaxal/search-list-box
command palette
source
https://gist.github.com/Metaxal/d06f50a2534ca229309e71a2d244a912
the others listed
I'm hesitant (in the sense of undecided) about including default scripts for the following reasons:
I'm not sure anyone uses the pasterack
script, so probably not the best one to include.
url2script
is pretty useful, but it downloads directly for the Internet, so trust/responsibilities considerations.
open-terminal
is probably innocuous but some multi-platform testing would be in order to make it robust for the largest number.
visit-url
had some issues at some point when I tried it, but that should be fixable. I don't really use it much though.
eyes
are probably the best script to add: simple, fun, no trust issue, should work just fine.
command-palette
is a useful script, but has dependency on search-list-box. That said, I do believe something like search-list-box
should be part of racket/gui :p
The scripts I use the most:
text-block
and search-list-box
)i can verify open terminal works on windows and macOS I'll be happy if i we can get that and eyes included.
If @rfindler approves command pallette/search-list-box i will be ecstatic.
I am more than happy to trust @Metaxal 's judgment in this matter. He has a very nuanced and thoughtful take, as above. If there are questions about dependencies, I'm happy to look into those, of course :).
As much as I'd like to include url2script
, I prefer to stay on the cautious side and keep it out of the main distribution for now.
For command-palette
, maybe we should first try to get search-list-box
in the main distribution. But I think Alex Harsanyi has something similar so it may be a good idea to try to merge the two tools and functionalities first. (Downside: to keep backward compatibility, the two old tools should still exist, which means creating a third one...) Hence, that can be a lot of work :/
(edit: I didn't mean to close the issue...)
Other implementations of 'search-list-box'
Can we start with Open Terminal, so it shows up in nightly releases ?
While we have some time till the next release - we can cautiously test it - if it goes badly we can pull it before 8.4. (I don't think it will go badly - I think it will go well)
I can do a PR - I'll copy the mechanism used by -extra
Quickscript installed with no scripts is counterproductive if users see no scripts they won't investigate further - defeating the point of including a scripts functionality in DrRacket.
I'd propose the following is installed by default
of course there may be others that are better choices but I'd suggest
command-palette
,url2script
andopen-terminal
as a minimum, and these scripts they do not grow the distribution in a way that is detectable.