Metaxal / rwind

Window manager in the Racket programming language
Other
87 stars 5 forks source link

Add Racket file launcher #9

Closed lehitoskin closed 9 years ago

lehitoskin commented 9 years ago

I disliked the idea of outsourcing the launcher to gmrun or dmenu, so I made a little application that would do the same thing.

Metaxal commented 9 years ago

That sounds cool, thanks! Quite busy now, but I'll take a deeper look next week end. So I'm actually not the only one to use RWind then?! :)

On Sun, May 10, 2015 at 10:45 PM, Lehi Toskin notifications@github.com wrote:

I disliked the idea of outsourcing the launcher to gmrun or dmenu, so I

made a little application that would do the same thing.

You can view, comment on, or merge this pull request online at:

https://github.com/Metaxal/rwind/pull/9 Commit Summary

  • Add Racket file launcher

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Metaxal/rwind/pull/9.

lehitoskin commented 9 years ago

Every now and then I'll login using Rwind, yeah. Definitely not forgotten :+1:

Metaxal commented 9 years ago

I've tested your launcher quickly this morning. A couple of remarks:

Do you think you can do that?

On Mon, May 11, 2015 at 9:40 AM, Lehi Toskin notifications@github.com wrote:

Every now and then I'll login using Rwind, yeah. Definitely not forgotten [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/Metaxal/rwind/pull/9#issuecomment-100817230.

lehitoskin commented 9 years ago

Keeping the launcher in memory is giving me problems that I cannot seem to solve. Command history and insertion when pressing "up" is a work in progress. Command completion is... on my todo list.

Metaxal commented 9 years ago

Some notes:

I will look at the last point sometime later.

On Wed, May 20, 2015 at 10:38 PM, Lehi Toskin notifications@github.com wrote:

Keeping the launcher in memory is giving me problems that I cannot seem to solve. Command history and insertion when pressing "up" is a work in progress. Command completion is... on my todo list.

— Reply to this email directly or view it on GitHub https://github.com/Metaxal/rwind/pull/9#issuecomment-104047018.

lehitoskin commented 9 years ago

What I meant was running the code as a module instead of a standalone script gives weird behaviors. When run as a script (with rwind-system) it operates as expected, but when run as part of the module the text area becomes inoperable. I've tried all manner of enables, disables, and goat sacrifices, but the result is always the same.

P.S. Which is to say, as far as I can tell, instantaneous reloading doesn't seem like a possibility.

Metaxal commented 9 years ago

Ah yes, I've had exactly the same problems. I haven't solved it entirely unfortunately. Anyway, the launcher is probably better as a separated program.

On Thu, May 21, 2015 at 12:22 AM, Lehi Toskin notifications@github.com wrote:

What I meant was running the code as a module instead of a standalone script gives weird behaviors. When run as a script (with rwind-system) it operates as expected, but when run as part of the module the text area becomes inoperable. I've tried all manner of enables, disables, and goat sacrifices, but the result is always the same.

— Reply to this email directly or view it on GitHub https://github.com/Metaxal/rwind/pull/9#issuecomment-104069998.

Metaxal commented 9 years ago

Your pull request has been merged, thanks a lot! I like your idea :)

I've made a few changes:

Btw, a bug has been fixed in X11 that was triggered by more thorough error checking in the latest Racket release. Be sure to update your x11 package too (e.g., raco pkg update x11 if you don't build it from source).

Thank you again for adding a feature to RWind, that's nice!

Metaxal commented 9 years ago

Aww, I've just seen that you added a commit in your pull request that I didn't sync with... (why didn't I receive an automatic email about that?). Command history, that's cool!

I'll make a few comments directly on the files

Metaxal commented 9 years ago

Pfew, ok, damage repaired. I merge your history cycling with the command completion. I rolled back to using just a text-field% as it's simpler (and is actually still a text% in disguise, which can be retrieved through get-editor). For simplicity, I also used a zipper instead of a hash to manage the history cycling. I hope it's fine with you.

This gmrun replacement is really nice, good job!