Closed muellch closed 3 years ago
launch jenkins
launch jenkins
@muellch about the two points you mention in the description, I'd say yes, they could be done as followups to this PR if you still think AST refactorings are still worth your time.
launch jenkins
@muellch Squash and merge at your will, as PR is approved and build is green
Technical Description
Gets rid of the SIR<-> AST circular dependencies resolving https://github.com/MeteoSwiss-APN/dawn/issues/319 and partially resolving https://github.com/MeteoSwiss-APN/dawn/issues/320.
The most important change is the separation of anything related to
class sir::VerticalRegion
, includingclass ast::VerticalRegionDeclStmt
, into separate filesVerticalRegion.h
andVerticalRegion.cpp
. In these filesclass sir::VerticalRegion
remains defined as part of thesri
namespace, whileast::VerticalRegionDeclStmt
remains defined as part of the namespaceast
.Other noteworthy changes:
class sri::Value
,class sri::Interval
andclass sri::Attr
have all been extracted into according header and.cpp
files and moved to the namespacdast
.sir
andiir
aliased ofast
classes have been removed.#include
directives have been cleaned up throughout the project (Thank you CLion).Future discussions and TODOs:
sri
namespace, such asclass sri::StencilFunction
orclass sri::Field
also be extracted into separate files and moved into theast
namespace?