search

Meteor-Community-Packages / Meteor-CollectionFS

Reactive file manager for Meteor
MIT License
1.05k stars 237 forks source link

app crashes if temp filesystem store does not have sufficient permissions #562

Open mxab opened 9 years ago

mxab commented 9 years ago

Hi, I just noticed that if you do not have the right permissions on the temp store folder the app crashes if you upload a file. after I did chown -R meteoruser: path/to/app/cfs it worked again

wursttheke commented 9 years ago

There are several issues causing server crashes, all concerning different parts of the package as it seems.

Stability and better error handling is already on the trello board: https://trello.com/b/iFsuP745/meteor-collectionfs

I think what's needed is a general way to catch errors and report them back to the client.

(@mxab Grüße nach Hessen)

raix commented 9 years ago

Debugging tools needed - Maybe we should have a small cli tool + package for general debugging - perhaps have chrome hook on to a socket ?

Its ok if the system crashes but it should state the reason?

mxab commented 9 years ago

Hmm I would say it is never good if the system just crashes, I mean I had the EACCES error, but it did not make sense at that time, of course a well stated reason would be better but in general you do not want your app to crash if the user uploads a file

I not sure if I understand the idea with the chrome hook, you mean like a "monitoring ui"? I guess would be great but I this is more a discussion for the trello board :)

(@wursttheke kennen wir uns? :D )

raix commented 9 years ago

@mxab We dont want our server to stop - but missing rights prevents the system from working correctly, so a nice explanatory error message would be the proper result imho.

The devtools package would require that we added a debug package to cfs (we could make it a general one) - its on the cfs trelloboard already :) - I saw the devshop this morning and I think it was @Slava that demonstrated a very basic integration.

But I'm thinking more in terms of adding a general devtool tool integration allowing packages like ddp to add analytics / live-data monitoring subscriptions / ground db to debug and monitor cached data / cfs for filehandling debugging (error messages are a lot harder when working with streams so we need some tooling in order for us to reason about it)

So its basically a question about having a package that does the ui integration / live update / two way binding to the devtools - and having a nice api for debug packages to hook into.

aldeed commented 9 years ago

@aaronjudd, refresh my memory: what logging package did you end up choosing for reaction and why?

aaronjudd commented 9 years ago

@aldeed I'm using bunyan https://github.com/trentm/node-bunyan

my basic needs were: