search

Meteor-Community-Packages / check-npm-versions

Enforces "peer" npm dependencies in Meteor 1.3+ Atmosphere packages.
MIT License
11 stars 10 forks source link

Remove Underscore #20

Closed klaussner closed 6 years ago

klaussner commented 6 years ago

check-npm-versions uses Underscore without explicitly depending on it, which causes the issue described in #18: If no other Meteor package in .meteor/packages depends on Underscore, check-npm-versions throws TypeError: Cannot read property 'forEach' of undefined.

This PR replaces the used Underscore functions (_.forEach and _.keys) with Array.prototype.forEach and Object.keys.

Fixes #18.

benjamn commented 6 years ago

@tmeasday How should we proceed here? This is becoming more important since underscore is much more optional in Meteor 1.6.1.

tmeasday commented 6 years ago

Sorry, I wasn't getting notifications for this repository.

Happy to merge and release; but is someone interested in taking over this repository? I'm not currently using the package and if as @hwillson said it is important infrastructure for the Meteor community, someone who is probably should.

tmeasday commented 6 years ago

@klaussner -- would you like me to add you as a maintainer / give you publish rights?

tmeasday commented 6 years ago

Published as 0.3.2

hwillson commented 6 years ago

@tmeasday I'll gladly help maintain this repo is you're interested? Thanks!

tmeasday commented 6 years ago

@hwillson done--and I added you as a maintainer of the package.

hwillson commented 6 years ago

Awesome - thanks @tmeasday!