search

Meteor-Community-Packages / check-npm-versions

Enforces "peer" npm dependencies in Meteor 1.3+ Atmosphere packages.
MIT License
11 stars 10 forks source link

Dependency on meteor/underscore is not present in package.js #48

Closed vparpoil closed 3 months ago

vparpoil commented 3 months ago

In newer versions of Meteor, underscore is not bundled any more. Since underscore is used, it should be declared as a dependency. Issue is still present in 2.0.0-beta.0

check-npm-versions.js:16 Uncaught 
TypeError: Cannot read properties of undefined (reading 'forEach')
    at checkNpmVersions (check-npm-versions.js:16:5)

Best way to solve is to remove underscore

github-actions[bot] commented 3 months ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

vparpoil commented 3 months ago

My bad, this has been fixed with last versions