Remove using findOne leads to inconsistent state

Meteor-Community-Packages / ground-db

GroundDB is a thin layer providing Meteor offline database and methods

https://atmospherejs.com/ground/db

MIT License

572 stars 77 forks source link

Remove using findOne leads to inconsistent state #190

Open damonmaria opened 7 years ago

damonmaria commented 7 years ago

remove uses findOne to find the document to remove from localforage. This means that if the selector matches multiple documents then only one is removed from localforage, but all are removed from the Collection.

Also, that only one would be removed is inconsistent and non-obvious. Can all documents matching the selector be removed?

brucejo75 commented 5 years ago

This seem like a bug, the fix is simple. I have a PR coming.

brucejo75 commented 5 years ago

PR #209