search

Meteor-Community-Packages / meteor-autoform

AutoForm is a Meteor package that adds UI components and helpers to easily create basic forms with automatic insert and update events, and automatic reactive validation.
MIT License
1.44k stars 328 forks source link

Label icons for accessibility #1695

Closed emollett closed 4 years ago

emollett commented 4 years ago

The buttons to add or remove items have no accessible text for screen reader users.

aria-label added to add and remove buttons for the afArrayField for accessibility

jankapunkt commented 4 years ago

Hi @emollett

thank you for your contribution. Improving accessibility is always a good idea. However, we may have to consider that this component is used by non-English speakers, too. Thus, it needs to be configurable to let the developer define what word to display.

Please take a look at how the submit button label is defined in a quickForm. By default it is defined as Submit but you can easily override it using `button-content="Whatever submit text". I think this is the right way to go.

emollett commented 4 years ago

@jankapunkt thanks that makes sense. Thanks for the pointer on overriding the button content, my understanding had been this is just for the submit button and not the add/remove ones. I understand I can make my own template for these though. For now as a quick fix I'm adding content to the buttons with css which works for the accessibility needs in this instance.

jankapunkt commented 4 years ago

Hey @emollett no need to close the pr. You just add your changes as new commits to your fork and we squash-merge it all at the end into one commit.

I think you don't need a full template, just a helper and a reactive variable, as the submit button does.