search

Meteor-Community-Packages / meteor-autoform

AutoForm is a Meteor package that adds UI components and helpers to easily create basic forms with automatic insert and update events, and automatic reactive validation.
MIT License
1.44k stars 328 forks source link

Please add error/warning messages if no theme is installed #1731

Closed ebradbury closed 1 year ago

ebradbury commented 1 year ago

Now that autoform 7 decouples themes, you must manually install and activate a theme separately. But if you don't the form simply doesn't render and there are no client or server errors.

Could you please add an error/warning message if there is no theme installed or activated?

github-actions[bot] commented 1 year ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

jankapunkt commented 1 year ago

Should be not a big issue. Care to create a PR?

ebradbury commented 1 year ago

Something here? https://github.com/Meteor-Community-Packages/meteor-autoform/blob/devel/autoform-api.js#L311

jankapunkt commented 1 year ago

Yes, that's the line. Please also update the tests, which will be a bit more work but should be not that much either.