search

Meteor-Community-Packages / meteor-autoform

AutoForm is a Meteor package that adds UI components and helpers to easily create basic forms with automatic insert and update events, and automatic reactive validation.
MIT License
1.44k stars 328 forks source link

`mongo-object` NPM package as peer dependency #1742

Open manueltimita opened 2 months ago

manueltimita commented 2 months ago

The package aldeed:simple-schema also depends on mongo-object. AutoForm is used in conjunction with SimplSchema more often than not. So both packages end up including the same dependency twice in the final bundle.

Any reasons not to use the peer npm meteor approach?

@jankapunkt I am happy to send a PR. I'm just checking whether there is a known issue / reason why this hasn't been done.

github-actions[bot] commented 2 months ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

jankapunkt commented 2 months ago

Hi @manueltimita thanks for reporting. It makes sense, however I'm currently pinning the versions for compatibility as I have to review all changes and especially since they are not likely to be backwards compatible. A useful first approach would be to pin the versions with the npmDependencies package and then start to migrate to the latest possible versions.