search

Meteor-Community-Packages / meteor-browser-tests

A helper package for Meteor test driver packages. Runs client tests in a headless browser.
MIT License
12 stars 21 forks source link

Playwright not terminating when client tests are done #43

Closed Torgen closed 2 years ago

Torgen commented 2 years ago

Tried the new playwright browser driver with my app (https://github.com/Torgen/codex-blackboard in the playwright branch) and the client tests run, but the process never terminates. I'm running ubuntu 20.04 on WSL2, but my github actions runs have the same issue; the test command is TEST_BROWSER_DRIVER=playwright meteor npm run test.

StorytellerCZ commented 2 years ago

@hexsprite can you please take a look?

hexsprite commented 2 years ago

Yeah, I can confirm there is a problem. It looks like a conflict with Meteor's Promise implementation. I will have to create a bug report in the Meteor repo for this. Seems like this makes the playwright testing backend unusable at the moment...

Torgen commented 2 years ago

I tested this on my app, and while it terminated after running the unit tests, it still didn't terminate after full app tests.

StorytellerCZ commented 2 years ago

Let's create another issue for it.

hexsprite commented 2 years ago

@Torgen I am using the full app tests by default and it's working fine both when running locally and in CI. Does it happen in a fresh project with a minimal reproduction?