search

Meteor-Community-Packages / meteor-browser-tests

A helper package for Meteor test driver packages. Runs client tests in a headless browser.
MIT License
12 stars 21 forks source link

Set higher default and allow configuring puppeteer protocol timeout #58

Open make-github-pseudonymous-again opened 4 months ago

make-github-pseudonymous-again commented 4 months ago

I believes this should fix https://github.com/Meteor-Community-Packages/meteor-mocha/issues/104.

make-github-pseudonymous-again commented 4 months ago

@nachocodoner @jankapunkt @StorytellerCZ Will this require a backport to work in Meteor 2 or is the latest version compatible with both Meteor 2 and 3?

jankapunkt commented 4 months ago

@make-github-pseudonymous-again it's intended to work with both but please let me know if you encounter issues.

nachocodoner commented 4 months ago

So, did you stop to see the error after tweaking this timeout? If that is ok, it feels good to me to merge, just tweaking a timeout doesn't seem problematic.

make-github-pseudonymous-again commented 4 months ago

@nachocodoner If that question is for me, I did not test anything. Just assumed it would work.