Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks
https://atmospherejs.com/matb33/collection-hooks
MIT License
657 stars 92 forks source link

Accounts Testing included everywhere (!) #10

Closed tmeasday closed 11 years ago

tmeasday commented 11 years ago

Hey there,

I might be missing something, but I believe the accounts-testing package is making the Meteor.insecureUserLogin globally available in my Meteor app.

The reason for this is:

  1. Meteorite installs any package in smart.json into packages/
  2. Meteor automatically .use()s any package in packages/.

Point 2. will be addressed in the upcoming 0.6.5 release, but in the meantime (and for sometime afterwards), I would suggest that you should hold off on including those tests.

It's annoying I know.

matb33 commented 11 years ago

Yikes -- taking your advice and commenting out the tests.

matb33 commented 11 years ago

Done, see version 0.3.2

mizzao commented 11 years ago

Sorry about that, guys. I had been running against devel and didn't give a lot of thought to how to separate the testing packages from the others. Hopefully no one insecurely logged on during your brief period of security by obscurity :)

@tmeasday, do you foresee being able to add an option to meteorite to specify meteor-compatible versions for smart packages?