Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks
https://atmospherejs.com/matb33/collection-hooks
MIT License
657 stars 92 forks source link

Call for contributors #190

Closed matb33 closed 4 years ago

matb33 commented 8 years ago

I've been quite disappointed with how little time I've been able to put into this project. I have many false starts attempting to address some issues, but keep getting pulled away before I can finish.

One of these days I'll have time to switch gears and close off a bunch of issues, but that day isn't coming fast enough.

Is there anyone willing to help out and fix some of the more pressing issues?

I'd say probably these ones:

https://github.com/matb33/meteor-collection-hooks/issues/185 https://github.com/matb33/meteor-collection-hooks/issues/180 https://github.com/matb33/meteor-collection-hooks/issues/177 https://github.com/matb33/meteor-collection-hooks/issues/175 https://github.com/matb33/meteor-collection-hooks/issues/174 https://github.com/matb33/meteor-collection-hooks/issues/167 (generally speaking, probably want to depend on as many external packages that also mess with mutator methods so as to load predictably after them, and go from there) https://github.com/matb33/meteor-collection-hooks/issues/161 https://github.com/matb33/meteor-collection-hooks/issues/159 https://github.com/matb33/meteor-collection-hooks/issues/110 https://github.com/matb33/meteor-collection-hooks/issues/103

mizzao commented 8 years ago

I found this to be helpful for similar situations: http://felixge.de/2013/03/11/the-pull-request-hack.html

matb33 commented 8 years ago

I'm definitely game for that -- in fact I'm fairly certain I did exactly this with you @mizzao ;) Now to find more Andrews!

lawrentiy commented 7 years ago

No one answers? Strange for me, i thought, that`s popular package...

matb33 commented 7 years ago

Many thanks to @namirsab and now @zimme for stepping in and helping out, it's hugely appreciated

zimme commented 7 years ago

@matb33, I will need admin access on atmosphere if I am to publish a new version of this package.

matb33 commented 7 years ago

OK done, thanks @zimme!

zimme commented 7 years ago

@danv, @dburles, could you add me to the collection organization on atmosphere?

I'm working on a more import/export friendly version of my collection behaviours packages and also thinking about doing the same with this package.

Would be nice to put it under collection:hooks and collection:timestamp/collection:softremove etc.

SimonSimCity commented 5 years ago

@zimme are you still working on this project? Otherwise I'd volunteer to take a closer look at the currently remaining PRs and specially #246 which has been the reason for @sakulstra to fork off.

zimme commented 5 years ago

Don't really use meteor for any projects any longer and I don't really have time to maintain thid any more. I could give you access so you can do the changes you're talking about.

SimonSimCity commented 5 years ago

@zimme I would really appreciate it. Access to this repo and the package on atmosphere is all I need to be ready to kick it off 🎉 This would make it easier also for people who otherwise would have to find a well maintained fork or fork it themselves ...

sakulstra commented 5 years ago

sorry didn't see the ping - yeah i had to fork it due to #246 and #247, anyhow i'd rather switch back to a maintained/(used by other people) version so that i don't miss upstream fixes/improvements

SimonSimCity commented 5 years ago

Any chance someone has time and is willing to provide me access so I can fix at least the outstanding things provided in the previous message? @zimme @matb33 @namirsab @mizzao

zimme commented 5 years ago

I'll try and get to it this weekend but I can't promise anything as I've got a newborn here at home that takes priority :p

However please give me your atmosphere and npm usernames so have everything i need as soon as i get some time over :)

zimme commented 5 years ago

This goes for you too @sakulstra

mizzao commented 5 years ago

@SimonSimCity I'd add you but I can't; I don't have permission. I think @matb33 has to do it.

SimonSimCity commented 5 years ago

@zimme My username is simonsimcity on both of them.

p.s. I can fully understand this. Hope all is well at your side.

zimme commented 5 years ago

@matb33 I'm not a repo admin so I can't add @SimonSimCity as a contributor.

zimme commented 5 years ago

@SimonSimCity @sakulstra if we can't get an answer from Mathieu in say, maybe a couple of weeks, I'm happy to merge a PR with a notice in the README about this package being without maintainers and that whatever fork you want is recommended to use instead of this package.

I see this as the best option as I don't really see myself being able to maintain this package any longer as I don't work with Meteor on a daily basis any more.

I can also give you access to my collection behaviours packages if that is of interest to you.

SimonSimCity commented 5 years ago

We currently evaluate removing this plugin as it adds more uncontrolled magic to the code-base which can hide some traps. Our attempt goes into the direction of creating a custom wrapper for the collections where the hooks are explicitly referenced - no more magic.

For this reason I withdraw my vote for volunteering at the development of this package.

This package is definitively a good addition if you're rapidly prototyping, but for us it leaves an open door for introducing too much uncontrolled magic.

matb33 commented 5 years ago

For whatever reason I didn’t get notifications when you guys pinged me. Do any of you still need any action from me?