search

Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks
https://atmospherejs.com/matb33/collection-hooks
MIT License
657 stars 92 forks source link

Fix argument passing to Meteor.Collection.update. #2

Closed wizonesolutions closed 11 years ago

wizonesolutions commented 11 years ago

This only affects the overridden Meteor.Collection.update; no fixes are needed for insert or remove. This is because insert and remove only take 1 or 2 arguments, and passing a callback to them without a selector wouldn't make any sense anyway. However, not passing options to update (and terminating the invocation with a callback) is rather common.

matb33 commented 11 years ago

Minor tweaks + test and merged: 3b1bcf4277eb8033264f256cd522de61c911891a

Thanks wizonesolutions, good catch!

wizonesolutions commented 11 years ago

No problem. Nice tweaks! Is the new version published? I'm still using my modified copy.

matb33 commented 11 years ago

Yep, should be on atmosphere unless I did something wrong :)