Closed SimonSimCity closed 4 years ago
I'll create a second PR on the basis of this where I'll fix an error that should have been caught if eslint would've been used. @StorytellerCZ is it hard to include the linter in the CI?
I just realized that I pushed the three bug reports also in here ... so be it so ... Every of those three bugs has a test-case and I'm using most of these features in production these days.
All three were introduced now in 1.0.0 - and I can confirm that there were no other code-changes introduced in 1.0.0 other than these - as far as I've seen. Would be nice to get this merged soon.
I'm fine to release as 1.0.1. You are correct @SimonSimCity, we need to add eslint to CI. After this gets merge, let's make another PR for that.
LGTM, let's publish as 1.0.1. (And sorry for the sloppiness in the 1.0.0 rewrite)
Please be clear about who is responsible for publishing. If you want, I can also publish it.
I'm publishing it today after I update changelog and necessities.
Among the stuff with spaces and commas were some missing imports and some other small things ...