search

Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks
https://atmospherejs.com/matb33/collection-hooks
MIT License
657 stars 92 forks source link

Fix Autoform Submit Problem #283

Closed cpravetz closed 2 years ago

cpravetz commented 2 years ago

Fixes problem with callbacks being lost because args passed from autoform include a validation object while collection-hooks assumes only two args.

jankapunkt commented 2 years ago

@cpravetz thanks a lot this pull request. Can you please add a bit more info, for which AutoForm method or hook this fix is?

cpravetz commented 2 years ago

Sorry - the patch addresses issue #1710 in the meteor-autoform repo. The callback passed during submit gets lost when collection-hooks expects two arguments and autoform passes three - so actions after the actual collection submit happens are never called.

jankapunkt commented 2 years ago

Related: https://github.com/Meteor-Community-Packages/meteor-autoform/issues/1710

jankapunkt commented 2 years ago

@cpravetz all good @StorytellerCZ this can be merged and published. Can you do that?

copleykj commented 2 years ago

@jankapunkt you should have the ability to do that if you wanted to.

StorytellerCZ commented 2 years ago

Published in matb33:collection-hooks@1.1.3