search

Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks
https://atmospherejs.com/matb33/collection-hooks
MIT License
656 stars 90 forks source link

Add support for async collection methods #299

Closed jdgjsag67251 closed 10 months ago

jdgjsag67251 commented 10 months ago

See #288.

Ok, so apparently Meteor just internally calls the non-async methods and wraps them in a Promise: https://github.com/meteor/meteor/blob/devel/packages/mongo/collection.js#L998. This PR just adds tests to make sure that the hooks keep working when Meteor changes their implementation.

jdgjsag67251 commented 10 months ago

Cool, thnx. I've updated the PR.

jankapunkt commented 10 months ago

That's great @jdgjsag67251 :+1: Thanks a lot! @StorytellerCZ lgtm, can be merged