search

Meteor-Community-Packages / meteor-collection-hooks

Meteor Collection Hooks
https://atmospherejs.com/matb33/collection-hooks
MIT License
657 stars 92 forks source link

MDN Function.prototype.bind() polyfill throws error in ie8 #77

Closed BenAHammond closed 9 years ago

BenAHammond commented 9 years ago

The polyfill begins with this section:

if (!Function.prototype.bind) { // 3 Function.prototype.bind = function (oThis) { // 4 if (typeof this !== "function") { // 5 // closest thing possible to the ECMAScript 5 internal IsCallable function // 6 throw new TypeError("Function.prototype.bind - what is trying to be bound is not callable"); // 7 }

Which is firing because, in my debugger, "typeof this" == Object.

Help! I need your package and I need IE8 support!

matb33 commented 9 years ago

I can't recall why the polyfill is there. Possibly leftover from legacy code. I'll look at this soon.

BenAHammond commented 9 years ago

You're a lifesaver, thank you!

matb33 commented 9 years ago

I removed the bind polyfill in 0.7.7

BenAHammond commented 9 years ago

Thank you!

On Mon, Dec 22, 2014 at 12:43 PM, Mathieu Bouchard <notifications@github.com

wrote:

I removed the bind polyfill in 0.7.7

— Reply to this email directly or view it on GitHub https://github.com/matb33/meteor-collection-hooks/issues/77#issuecomment-67887167 .