search

Meteor-Community-Packages / meteor-collection2

A Meteor package that extends Mongo.Collection to provide support for specifying a schema and then validating against that schema when inserting and updating.
https://packosphere.com/aldeed/collection2
MIT License
1.02k stars 108 forks source link

Fix #408 #409

Closed harryadel closed 4 years ago

harryadel commented 4 years ago

Added upsert vanilla nested objects which doesn't logical operators value test case for #408

harryadel commented 4 years ago

@SimonSimCity and @Rijk would you please guys give it a look?

SimonSimCity commented 4 years ago

So .... could you please split it up your changes into a section of your actual changes and all the rest which is just related to some code-stylings? 😊

harryadel commented 4 years ago

Yes, right away. Sorry!

rijk commented 4 years ago

Wow, that was quick. Tested and confirmed it fixes the issue 💪

harryadel commented 4 years ago

@SimonSimCity Done!

I'm glad it's working @Rijk but I was thinking in terms of code quality. Do you think it's good enough?

SimonSimCity commented 4 years ago

Yes, looks good 👍

harryadel commented 4 years ago

Alright then, thank you guys!

harryadel commented 4 years ago

@Rijk Please update your project. :)

rijk commented 4 years ago

Thanks Harry!

copleykj commented 4 years ago

@harryadelb nice turn around time.