Modernize & fix #422 - Githubissues

Meteor-Community-Packages / meteor-collection2

A Meteor package that extends Mongo.Collection to provide support for specifying a schema and then validating against that schema when inserting and updating.

https://packosphere.com/aldeed/collection2

MIT License

1.02k stars 108 forks source link

Modernize & fix #422 #426

Closed StorytellerCZ closed 3 years ago

StorytellerCZ commented 3 years ago

Table of Contents generated with DocToc

What
Why

What

Modernize code
Remove unused dependency clone
Fix #422
Fix LGTM errors

Why

As far as I and my IDE has seen clone is no longer used, please correct me if I'm missing something here.

Then I have updated var to let and const and one loop for forEach loop.

Finally this PR also includes a proposed solution for #422.

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts and fixes 1 when merging 6b03016757658e1557c18ae8dd795026fc53f0ec into 55d3998d43ac245c2c40d5322c737978c2a4ea5c - view on LGTM.com

new alerts:

2 for Assignment to constant

fixed alerts:

1 for Unused variable, import, function or class

harryadel commented 3 years ago

You seem to be still making modifications. :sweat_smile: Please let me know when you're done.

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts and fixes 1 when merging 65f99cc1695c873e666e9d422c0c93473199b1f6 into e8ec933765a9dc6e83244f28e0c95cc04260b4b7 - view on LGTM.com

new alerts:

2 for Assignment to constant

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging a1641612d53e49799b0dafc62562ed5051ab0f52 into e8ec933765a9dc6e83244f28e0c95cc04260b4b7 - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types
1 for Unused variable, import, function or class

StorytellerCZ commented 3 years ago

@harryadel sorry, noticed the LGTM errors so I went ahead and fixed them. There was actually one bug in that.

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging 8ac80e72b9823fcdf2c103109702be31a93d345d into e8ec933765a9dc6e83244f28e0c95cc04260b4b7 - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types
1 for Unused variable, import, function or class

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging afdb12564c2eb0a6e3a5e55595f79951539c5540 into e8ec933765a9dc6e83244f28e0c95cc04260b4b7 - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types
1 for Unused variable, import, function or class