search

Meteor-Community-Packages / meteor-collection2

A Meteor package that extends Mongo.Collection to provide support for specifying a schema and then validating against that schema when inserting and updating.
https://packosphere.com/aldeed/collection2
MIT License
1.02k stars 108 forks source link

Support for asynchronous mongo methods #443

Closed klablink closed 8 months ago

klablink commented 11 months ago

The implementation includes support for Meteor versions: 2.2, 2.13.3 and 3.0-alpha.15. This involved a considerable change to the code due to the fact that the three versions have a different way of handling remote collections. As expressed in the forum, we still have behaviour to clarify in version 3 in order to declare the work completed.

dallman2 commented 8 months ago

Any progress on this? @klablink @jankapunkt currently, I cannot get this package to play nicely with Meteor 3.0 alpha 19...

harryadel commented 8 months ago

I'll taking a look at this @dallman2, no worries

dallman2 commented 8 months ago

@harryadel FYSA, I found a dependency issue while trying to make all this work with meteor 3. It seems that SimplSchema has moved to ES6 style imports. While looking into it, I found that this workaround was the generally accepted solution for working with SimplSchema (for the time being): https://github.com/jankapunkt/simple-schema-3

In the README for that repo, they state that the imports have to be updated to ES6 style (although I suspect there is a typo). Either way, I think that for collection2 to use SimplSchema, this line needs to use ES6 import syntax... I could be wrong though:)

This is the error that I am getting on startup currently on alpha 19.

W20231214-15:26:04.532(-8)? (STDERR) ReferenceError: SimpleSchema is not defined
W20231214-15:26:04.532(-8)? (STDERR)     at packages/aldeed_collection2.js:31:1
W20231214-15:26:04.532(-8)? (STDERR)     at packages/aldeed_collection2.js:568:4
W20231214-15:26:04.532(-8)? (STDERR)     at packages/aldeed_collection2.js:572:4
W20231214-15:26:04.533(-8)? (STDERR)     at load (packages/core-runtime.js:139:16)
W20231214-15:26:04.533(-8)? (STDERR)     at onDepLoaded (packages/core-runtime.js:118:7)
W20231214-15:26:04.533(-8)? (STDERR)     at packages/core-runtime.js:153:7
W20231214-15:26:04.533(-8)? (STDERR)     at Array.forEach (<anonymous>)
W20231214-15:26:04.533(-8)? (STDERR)     at packages/core-runtime.js:152:22
W20231214-15:26:04.533(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:179:14)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
W20231214-15:26:04.534(-8)? (STDERR)     at evaluateNextModule (packages/core-runtime.js:218:7)
jankapunkt commented 8 months ago

Yeah the situation with simple schema is really frustrating. I will look into this later today

dallman2 commented 8 months ago

Yeah the situation with simple schema is really frustrating. I will look into this later today

The fix that I had suggested seemed to work, but I've ben working on other dependency issues, so I cannot verify that the complete correctness of the fix...

harryadel commented 8 months ago

@klablink I'm trying to push changes but it appears you've disabled the maintainers the ability to edit the PR, can you revert it?