search

Meteor-Community-Packages / meteor-collection2

A Meteor package that extends Mongo.Collection to provide support for specifying a schema and then validating against that schema when inserting and updating.
https://packosphere.com/aldeed/collection2
MIT License
1.02k stars 108 forks source link

4.0 load function is not dynamic #446

Closed jankapunkt closed 4 months ago

jankapunkt commented 5 months ago

In dynamic.js the load function is actually no real dynamic import

Actual: a nested import

Collection2.load = function () {
    import './main';
}

Expected: a dynamic import

Collection2.load = async function () {
    await import('./main')
}
github-actions[bot] commented 5 months ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

harryadel commented 5 months ago

Thanks for pointing that out, start and merge. I think you've maintainers rights here. If not start a PR and I'll merge it.