search

Meteor-Community-Packages / meteor-desktop

Build a Meteor's desktop client with hot code push.
MIT License
38 stars 12 forks source link

Support for meteor protocol with fetch #18

Closed MatejJan closed 1 year ago

MatejJan commented 1 year ago

Since meteor deprecated the http package, they suggest to use fetch instead. However, fetch does not by default like the meteor:// protocol that meteor-desktop uses (for example, to fetch files from the public folder).

From what I tested so far, the fix is simple. In the skeleton app, supportFetchAPI: true (doc) must be added in line 35:

electron.protocol.registerSchemesAsPrivileged([
  { scheme: 'meteor', privileges: { standard: true, secure: true, supportFetchAPI: true } }
]);

I don't know if this has any negative side effects however. But if not, it would be great if this is the default.

github-actions[bot] commented 1 year ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know