search

Meteor-Community-Packages / meteor-link-accounts

Meteor link account package. based on this PR https://github.com/meteor/meteor/pull/1133
https://atmospherejs.com/bozhao/link-accounts
MIT License
116 stars 56 forks source link

Changed linkedIn oauth package for LinkedIn api V2 #81

Closed agustinjch closed 5 years ago

agustinjch commented 5 years ago

Previous Oauth package for LinkedIn wasn't working anymore due to deprecated V1 API in LinkedIn

I changed the needed package for this, from jonperl:linkedin to pauli:linkedin-oauth

yubozhao commented 5 years ago

Thanks, let me ping @StorytellerCZ for his approvals. If he pass it, I will merge in and publish

Thanks for contributing @agustinjch

StorytellerCZ commented 5 years ago

Hi @agustinjch Thank you for your contribution. Please also make a change in the readme and add a note about this into the changelog. We have to also consider if we want to replace the existing way or maybe add the new LinkedIn package as another option and leave the existing one with a log warning for right now. I think depreciation and adding the new package would be the best way as removing package like this would require a major version bump, which I would like to avoid for now.

HuthDev commented 5 years ago

Status?

yubozhao commented 5 years ago

i will update the package, if the PR is merged

StorytellerCZ commented 5 years ago

@yubozhao I've made the changes and added changelog entries, etc. Please check the file and if everything is correct, then we can publish a new version.

yubozhao commented 5 years ago

@StorytellerCZ I will publish it. Thank you for the heads up!

Edit: Just published version 2.1.0 Thank you @agustinjch for contributing and @StorytellerCZ for editing and reviewing!