Meteor-Community-Packages / meteor-publish-composite

Meteor.publishComposite provides a flexible way to publish a set of related documents from various collections using a reactive join
https://atmospherejs.com/reywood/publish-composite
MIT License
553 stars 58 forks source link

Reversing #177 & additional tests #182

Closed manueltimita closed 6 months ago

manueltimita commented 6 months ago

Reversing #177. Implemented additional tests to try and catch the reported behaviour (see discussion).

What

It was reported that changed is not properly triggered in subscription when an array property in a child publication is being updated. Tests were added to validate whether this is indeed the case. The results so far point to changed being triggered without problems under the reported circumstances.

Additionally:

Why

PR #177 proposes a change which may lead to unexpected behaviour. The new tests show that either with, or without this change, the updates are propagated without any visible issues. If the problem persists, the test suite should be expanded with the exact case that reproduces the issue.

StorytellerCZ commented 6 months ago

Will be released in v1.8.8