search

Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
921 stars 167 forks source link

Added a method to check inheritance of roles #234

Closed SimonSimCity closed 5 years ago

SimonSimCity commented 7 years ago

I've added a method where you can check if a role is inherited by another one. The need upstood when passing a role to a method and the server should verify, that this role contains another one - so the user at least has a specific role, but keeps the roles, that can be passed to this method, flexible.

SimonSimCity commented 7 years ago

@alanning What's your feedback on this one? Just wanted to ask because it has been lying around here for quite a while now and you merged one of my other PRs here...

SimonSimCity commented 7 years ago

@alanning Thanks for the quick review. I've now updated the code and I guess I've covered all of your notes.

SimonSimCity commented 7 years ago

Updated the code. What about now @mitar ?

SimonSimCity commented 6 years ago

@mitar sorry for having this waiting for soo long now. I've just updated the code according to your comments. Anything left?