Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
921 stars 169 forks source link

[Suggestion] remove unnecessary dependencies #235

Closed saeedjalalisj closed 5 years ago

saeedjalalisj commented 7 years ago

Hi @mitar @alanning , Today I trying to update meteor to 1.4.3.2 and give the below message:

Newer versions of the following indirect dependencies are available:
 * blaze 2.1.9 (2.3.0 is available)           
To update one or more of these packages, pass their names to 
`meteor update`, or just run `meteor update --all-packages`.

My project is independent from Blaze.js and based on React.js but your package is depend on Blaze.js. can you remove Blaze.js dependency please or still make it as a separate package for example meteor-roles-blaze?

Thanks for your attention.

mitar commented 7 years ago

Yea, Blaze could be made a weak dependency. Care to do PRs for both v1.0 and v2.0?

mitar commented 7 years ago

Oh, Blaze is already a weak dependency. So I am not sure what is happening here.

saeedjalalisj commented 7 years ago

This is my meteor list output:

accounts-base            1.2.15  A user account system
accounts-password        1.3.4  Password support for accounts
alanning:roles           1.2.16  Authorization package for Meteor
aldeed:collection2-core  2.0.0  Core package for aldeed:collection2
ecmascript               0.6.3  Compiler plugin that supports ES2015+ in all .js files
es5-shim                 4.6.15  Shims and polyfills to improve ECMAScript 5 support
jquery                   1.11.10  Manipulate the DOM using CSS selectors
less                     2.7.9  Leaner CSS language
meteor-base              1.0.4  Packages that every Meteor app needs
mobile-experience        1.0.4  Packages for a great mobile user experience
mongo                    1.1.16  Adaptor for using MongoDB and Minimongo over DDP
react-meteor-data        0.2.9  React mixin for reactively tracking Meteor data
reactive-var             1.0.11  Reactive variable
shell-server             0.2.3  Server-side component of the `meteor shell` command.
standard-minifier-css    1.3.4  Standard css minifier used with Meteor apps by default.
standard-minifier-js     1.2.3  Standard javascript minifiers used with Meteor apps by default.
static-html              1.2.0  Define static page content in .html files
tracker                  1.1.2  Dependency tracker to allow reactive callbacks

Maybe this dependency is for other packages ?

paulincai commented 6 years ago

Hi,

any chance for a separation from jquery?

Tx, Paul screen shot 2018-08-16 at 16 52 59

mitar commented 6 years ago

Blaze is a weak dependency. You can remove it from your project and it will not be forced by this package.

paulincai commented 6 years ago

I've got not blaze and no jquery in my packages setup. There is no other way to remove Blaze other than removing it from packages and I am 100% sure I don't have it. I am past this: https://github.com/meteor/meteor/issues/6844#issuecomment-282188007 and only get Blaze and jquery from the 2 sources listed above.

mitar commented 6 years ago

Yes. So accounts-base is forcing it, so you have it.

paulincai commented 6 years ago

Line 28-30 in the accounts-base:

  // If the 'blaze' package is loaded, we'll define some helpers like
  // {{currentUser}}.  If not, no biggie.
  api.use('blaze', 'client', {weak: true});

Would you think accounts-base is also on a weak dependency?

mitar commented 6 years ago

Have you tried meteor remove blaze?

paulincai commented 6 years ago

blaze is not a direct dependency in this project.
mitar commented 6 years ago

I have no idea. Maybe raise the issue on Meteor issue tracker?

mitar commented 5 years ago

This needs a better reproduction before it can be acted upon.