search

Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
921 stars 166 forks source link

Add CI to the repository to run tests for all branches/versions #285

Closed mitar closed 6 months ago

SimonSimCity commented 4 years ago

Updated the branches master and v2 to have npm commands for running tests. We only need to ensure that we have an environment where meteor is installed and we can go ahead calling npm test.

trudeaua21 commented 2 years ago

I think I'm gonna give this a go using GitHub Actions for Hacktoberfest if that's alright - let me know if that's not the route everyone would prefer, or if it's not needed anymore!

copleykj commented 2 years ago

I personally think that would be awesome.

trudeaua21 commented 2 years ago

Just a heads up on this - setting the GitHub Action up to actually run the testing command was pretty simple, but both locally and on the GitHub workflow machine I was having trouble either (a) getting the tests to run and/or (b) getting the coverage report to generate properly (depending on things like Meteor version, whether I npm install/ci beforehand, etc.)

I'm willing to do some digging into how this can be fixed (or, rather, how to run the tests properly to avoid this), and possibly updating some parts of the testing tools (i.e. switching out the deprecated istanbul for their recommended replacement nyc) if that's alright. I just want to make sure that that's alright and that it's not a breaking change or anything first!

StorytellerCZ commented 6 months ago

@trudeaua21 any additional works on the CI is welcome! Since we have GitHub Actions running now I'm closing this issue.