The function _getInheritedRoleNames() is currently used to construct the array inheritedRoles on a role-assignment, where it only takes over the parameter _id. If you have data stored on the role, wouldn't it be better to have it copied along?
If one of these parameter changes, the programmer extending this package would then be responsible for also keeping this data updated there. If he doesn't need it there, he can extend this package wrapping this function to remove the additional properties.
https://github.com/Meteor-Community-Packages/meteor-roles/blob/32c230ded9cb92b27a3485d143cabf2732fef186/roles/roles_common.js#L543-L557
The function
_getInheritedRoleNames()is currently used to construct the arrayinheritedRoleson a role-assignment, where it only takes over the parameter_id. If you have data stored on the role, wouldn't it be better to have it copied along?If one of these parameter changes, the programmer extending this package would then be responsible for also keeping this data updated there. If he doesn't need it there, he can extend this package wrapping this function to remove the additional properties.