Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
920 stars 164 forks source link

Defaut publication uses only user._id, but no index is created on that field only #360

Open armellarcier opened 1 year ago

armellarcier commented 1 year ago

I have slow login method response times (10 seconds for 10 000 role assignments).

Could the Meteor.roleAssignment.find({ 'user._id': this.userId }); be faster with an index on user._id ?

github-actions[bot] commented 1 year ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

StorytellerCZ commented 1 year ago

Yes, that could improve things. @armellarcier are you searching for this on your own or is it when calling a specific function from the package? Looking through the code there seem to be scenarios when using anyScope: true might result with a selector with only user ID.