search

Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
920 stars 164 forks source link

changed `userIsInRole` to be async #391

Closed dallman2 closed 4 months ago

dallman2 commented 4 months ago

for use with the open version 4 pr

dallman2 commented 4 months ago

Just checked out the reason the tests are failing. All of the tests seem to not expect this method to be async, which makes sense. Is there any larger effort underway to remake the tests to be async?

StorytellerCZ commented 4 months ago

I've checked and I think there is a bit of a misunderstanding here. We already have the async version of this function in roles_common_async. I guess the next step is that the current roles_common will become just roles_client in v4 as on server we will only be able to use async.

dallman2 commented 4 months ago

That makes a lot of sense. I will clone the current pr for v4 and see if i can get it running locally using the async stuff you referenced