search

Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
920 stars 167 forks source link

Add missing ddp dependency #394

Closed StorytellerCZ closed 5 months ago

StorytellerCZ commented 5 months ago

Also updates the Blaze weak dependency

Meteor 2 is very forgiving of not listing dependencies like ddp, but given how packages are loaded in Meteor 3 this will cause trouble. Hence adding the dependency directly.

jankapunkt commented 5 months ago

LGTM we should update the CI though and add 3.x tests but I'd prefer it in a separate PR @StorytellerCZ

StorytellerCZ commented 5 months ago

@jankapunkt I have another PR for that: #379