search

Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
920 stars 167 forks source link

Not async? #395

Closed carlosalvidrez closed 4 months ago

carlosalvidrez commented 4 months ago

Describe the bug

Meteor migration helper reports the server _roles method not being async.

W20240516-13:25:36.457(-4)? (STDERR) Deprecated (Publication): _roles is not async, consider migrating now. W20240516-13:25:36.457(-4)? (STDERR) => at module (packages/alanning:roles/roles/roles_server.js:30:8)

Expected behavior

I assume the presence of the meteor migration helper package should NOT report the serve roles method being not async. https://github.com/jankapunkt/meteor-migration-helper

Additional context

Migrating to Meteor v3, using the latest version of this package.

github-actions[bot] commented 4 months ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

carlosalvidrez commented 4 months ago

Another debug report that may be helpful, thanks!

Deprecated: Collection.findOne needs to be migrated to findOneAsync in collection "roles"! => at Object._addUserToRole (packages/alanning:roles/roles/roles_common.js:463:31)

carlosalvidrez commented 4 months ago

Not sure this is valid after all... now that I upgraded to v3, this doesn't happen anymore, thanks!